Code Formatting Conventions: Difference between revisions

From OpenMW Wiki
Jump to navigation Jump to search
(cleanup)
Line 2: Line 2:


This is an example of the layout & indention style we encourage.
This is an example of the layout & indention style we encourage.
<syntaxhighlight lang="cpp">
namespace SomeSpace
{
    class SomeClass
    {
        private:
            int mSomeVar;
 
        public:
            float someFunction(float p1, float p2) const;
    };
}


<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  namespace SomeSpace
 
  {
  <span class="kw2">namespace</span> SomeSpace
     float SomeClass::someFunction(float p1, float p2) const
  <span class="br0">{</span>
     {
     <span class="kw2">class</span> SomeClass
         return p1 + p2;
    <span class="br0">{</span>
     }
        <span class="kw2">private</span><span class="sy4"><nowiki>:</nowiki></span>
  }
 
</syntaxhighlight>
            <span class="kw4">int</span> mSomeVar<span class="sy4"><nowiki>;</nowiki></span>
 
        <span class="kw2">public</span><span class="sy4"><nowiki>:</nowiki></span>
 
            <span class="kw4">float</span> someFunction <span class="br0">(</span><span class="kw4">float</span> p1, <span class="kw4">float</span> p2<span class="br0">)</span> <span class="kw4">const</span><span class="sy4"><nowiki>;</nowiki></span>
    <span class="br0">}</span><span class="sy4"><nowiki>;</nowiki></span>
<span class="br0">}</span>
 
</font></div></div><div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
 
<span class="kw2">namespace</span> SomeSpace
<span class="br0">{</span>
    <span class="kw4">float</span> SomeClass<span class="sy4"><nowiki>::</nowiki></span><span class="me2">someFunction</span> <span class="br0">(</span><span class="kw4">float</span> p1, <span class="kw4">float</span> p2<span class="br0">)</span> <span class="kw4">const</span>
     <span class="br0">{</span>
         <span class="kw1">return</span> p1 + <span class="sy2"> </span>p2<span class="sy4"><nowiki>;</nowiki></span>
     <span class="br0">}</span>
  <span class="br0">}</span>
 
</font></div></div>


Note that the indention width is 4 spaces. We are not too strict about these rules, but if you use tabs instead of spaces, you have a decent chance to piss us off. Mixing spaces and tabs is '''not''' good.
Note that the indention width is 4 spaces. We are not too strict about these rules, but if you use tabs instead of spaces, you have a decent chance to piss us off. Mixing spaces and tabs is '''not''' good.
Line 42: Line 35:


Example:
Example:
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include <string>
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include &lt;string&gt;</nowiki></span>
 
</font></div></div>


C headers (if any) should be listed before the C++ headers.
C headers (if any) should be listed before the C++ headers.


===External libraries headers===
===External libraries headers===
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include <OgreVector3.h>
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include &lt;OgreVector3.h&gt;</nowiki></span>
 
</font></div></div>


If more than one external library is used, each library's headers should be put into a separate group.
If more than one external library is used, each library's headers should be put into a separate group.
Line 64: Line 51:


OpenEngine and mangle.
OpenEngine and mangle.
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include <openengine/ogre/renderer.hpp>
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include &lt;openengine/ogre/renderer.hpp&gt;</nowiki></span>
 
</font></div></div>


If both OpenEngine and mangle are present, mangle includes should be put into a separate group listed before the OpenEngine includes.
If both OpenEngine and mangle are present, mangle includes should be put into a separate group listed before the OpenEngine includes.


Note: If you are including from OpenEngine you would instead write:
Note: If you are including from OpenEngine you would instead write:
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include "renderer.hpp"
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include "renderer.hpp"</nowiki></span>
 
</font></div></div>


or
or


<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
<syntaxhighlight lang="cpp">
 
  #include "ogre/renderer.hpp"
  <span class="co2"><nowiki>#include "ogre/renderer.hpp"</nowiki></span>
</syntaxhighlight>
 
</font></div></div>


or even
or even
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include "../renderer.hpp"
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include "../renderer.hpp"</nowiki></span>
 
</font></div></div>


depending on the directory, where the including file is located. This rule applies to the following groups too.
depending on the directory, where the including file is located. This rule applies to the following groups too.


===Components headers===
===Components headers===
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include <components/compiler/context.hpp>
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include &lt;ocomponents/compiler/context.hpp&gt;</nowiki></span>
 
</font></div></div>


===Apps headers===
===Apps headers===
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include <mwworld/world.hpp>
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include &lt;mwworld/world.hpp&gt;</nowiki></span>
 
</font></div></div>


===Local headers===
===Local headers===
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  #include "world.hpp"
 
</syntaxhighlight>
  <span class="co2"><nowiki>#include "world.hpp"</nowiki></span>
 
</font></div></div>


==Doxygen Comments==
==Doxygen Comments==
Line 128: Line 95:


A class should be documented like this:
A class should be documented like this:
 
<syntaxhighlight lang="cpp">
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
  /// \brief short description
 
  ///
  <span class="co1">/// \brief short description</span>
  /// Longer description.
  <span class="co1">///</span>
  class SomeClass
  <span class="co1">/// Longer description.</span>
</syntaxhighlight>
  <span class="kw2">class</span> SomeClass
 
</font></div></div>


The longer description can be skipped, if there is nothing more to say.
The longer description can be skipped, if there is nothing more to say.


A function should be documented like this:
A function should be documented like this:
<syntaxhighlight lang="cpp">
/// Description.
void someFunction();
</syntaxhighlight>


<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
Here is a link to the [http://www.stack.nl/~dimitri/doxygen/commands.html Doxygen Documentation]. Please make plenty of use of the listed commands, especially the following:
 
<span class="co1">/// Description.</span>
<span class="kw4">void</span> someFunction<span class="br0">(</span><span class="br0">)</span><span class="sy4"><nowiki>;</nowiki></span>
 
</font></div></div>
 
or this:
 
<div dir="ltr" style="text-align: left"><div class="source-cpp"><font face="monospace">
 
<span class="kw4">void</span> someFunction<span class="br0">(</span><span class="br0">)</span><span class="sy4"><nowiki>;</nowiki></span>
<span class="co1">///&lt; Description.</span>
 
</font></div></div>
 
<br /> Here is a link to the [http://www.stack.nl/~dimitri/doxygen/commands.html Doxygen Documentation]. Please make plenty of use of the listed commands, especially the following:


* \a
* \a

Revision as of 17:52, 8 August 2011

Layout & Indention

This is an example of the layout & indention style we encourage.

 namespace SomeSpace
 {
     class SomeClass
     {
         private:
            int mSomeVar;
  
         public:
            float someFunction(float p1, float p2) const;
     };
 }

 namespace SomeSpace
 {
     float SomeClass::someFunction(float p1, float p2) const
     {
         return p1 + p2;
     }
 }

Note that the indention width is 4 spaces. We are not too strict about these rules, but if you use tabs instead of spaces, you have a decent chance to piss us off. Mixing spaces and tabs is not good.

Includes

An implementation file (cpp) should always start by including its own header.

Further includes should be grouped. Groups must be separated by an empty line.

Standard C and C++ headers

Example:

 #include <string>

C headers (if any) should be listed before the C++ headers.

External libraries headers

 #include <OgreVector3.h>

If more than one external library is used, each library's headers should be put into a separate group.

OpenMW-related library headers

OpenEngine and mangle.

 #include <openengine/ogre/renderer.hpp>

If both OpenEngine and mangle are present, mangle includes should be put into a separate group listed before the OpenEngine includes.

Note: If you are including from OpenEngine you would instead write:

 #include "renderer.hpp"

or

 #include "ogre/renderer.hpp"

or even

 #include "../renderer.hpp"

depending on the directory, where the including file is located. This rule applies to the following groups too.

Components headers

 #include <components/compiler/context.hpp>

Apps headers

 #include <mwworld/world.hpp>

Local headers

 #include "world.hpp"

Doxygen Comments

Class definitions and function declarations should have doxygen comments. We aren't very strict about this though (especially for trivial functions).

A class should be documented like this:

 /// \brief short description
 ///
 /// Longer description.
 class SomeClass

The longer description can be skipped, if there is nothing more to say.

A function should be documented like this:

 /// Description.
 void someFunction();

Here is a link to the Doxygen Documentation. Please make plenty of use of the listed commands, especially the following:

  • \a
  • \arg
  • \attention
  • \brief
  • \note
  • \p
  • \return
  • \todo